Details
-
Type:
Bug
-
Status: Done
-
Priority:
High
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 3.6.1
-
Component/s: cf-serverd
-
Labels:None
Description
We are debating with Kristian the following patch:
<pre>
— a/cf-serverd/cf-serverd-functions.c
+++ b/cf-serverd/cf-serverd-functions.c
@@ -362,17 +362,18 @@ static void CheckFileChanges(EvalContext *ctx, Policy **policy, GenericAgentConf
{
/* Rereading policies now, so update timestamp. */
config->agent_specific.daemon.last_validated_at = validated_at;
Log(LOG_LEVEL_VERBOSE, "New promises detected...");
if (GenericAgentArePromisesValid(config))
{
- Log(LOG_LEVEL_INFO, "Rereading policy file '%s'", config->input_file);
+ Log(LOG_LEVEL_NOTICE, "Rereading policy file '%s'", config->input_file);
/* STEP 1: Free everything */
EvalContextClear(ctx);
strcpy(VDOMAIN, "undefined.domain");
ClearAuthAndACLs();
</pre>
Essentially I wrote this because we never know if cf-serverd has read the new policy deployed and is working according to it. The only messages that cf-serverd currently logs to syslog is "starting server" and "shutting down". This patch would output the "reconfiguring" message to syslog as well.
Assigning to PM for judgement, CC'ing Kristian for the opposite opinion to be heard.