Uploaded image for project: 'CFEngine Community'
  1. CFEngine Community
  2. CFE-1954

Process promises that don't modify processes should be kept, not repaired

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.7.0
    • Labels:
      None

      Description

      Some uses of process promises do not modify the system in any way, e.g. they just set a class.
      In this case the promise is flagged as repaired today (both class- and reporting-wise AFIK).

      We should make them kept, ideally before 3.7.0beta (slight behaviour change although I don't believe people rely on this).

      The reason this is important now is that it is a glaring problem in the new Changes UI (see attachment:ootb-hub-process-changes.png).

      Minimum is that process: promises that only have restart_class (as process-specific attributes) are always flagged as kept.
      Ideally all process promises are kept unless either of @signals@ or @process_stop@ is defined.

        Attachments

          Activity

            People

            Assignee:
            a10040 Kristian Amlie
            Reporter:
            a10003 Eystein Maloy Stenberg
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: