Uploaded image for project: 'CFEngine Community'
  1. CFEngine Community
  2. CFE-2059

Remove or clarify report about running hardcoded failsafe from hardcoded failsafe/bootstrap policy

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Done
    • Priority: Low
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.7.2
    • Component/s: Logging
    • Labels:
      None

      Description

      This message is confusing and I am unsure what value it provides at this point.

      https://github.com/cfengine/core/blob/master/libpromises/failsafe.cf#L224-228

      <pre>
      "You are running a hard-coded failsafe. Please use the following command instead.
      $(sys.cf_agent) -f $(sys.inputdir)/update.cf"
      </pre>

      I believe this stems from the deconflation of updating from failsafe. At one time exec_command in body executor control was by default set to run failsafe.cf and then update.cf. I think that this report intended to warn users about the usage. update.cf has been in place for some time, and this policy is confusing new users. I think its best to just remove this report completely unless someone can think of a good reason to keep it.

      If we keep it then it at least needs to be guarded with @!bootstrap_mode@ so that it is not produced during bootstrap. And some suggestion to improve the report text would also be welcome, though I have no suggestion.

        Attachments

          Activity

            People

            • Assignee:
              a10003 Eystein Maloy Stenberg
              Reporter:
              a10042 Nick Anderson
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel