Uploaded image for project: 'CFEngine Community'
  1. CFEngine Community
  2. CFE-2253

convert functions to use consistent variable references

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Done
    • Priority: Medium
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.9.0
    • Component/s: Built-in functions
    • Labels:
      None

      Description

      The following functions should be reviewed so they all use VarRefValueToJson consistently and thus take old-style slists and new-style data containers. I believe this is the full list of functions that need review; the other functions don't deal with lists or data containers.

      Done:

      FnCallDataExpand
      FnCallEverySomeNone
      FnCallFilter
      FnCallFold
      FnCallFormat
      FnCallGetIndices
      FnCallGetValues
      FnCallGrep
      FnCallJoin
      FnCallLength
      FnCallMakerule
      FnCallMapData
      FnCallMapList
      FnCallMergeData
      FnCallNth
      FnCallProduct
      FnCallRegArray
      FnCallRegList
      FnCallReverse
      FnCallSetop
      FnCallShuffle
      FnCallSort
      FnCallStoreJson
      FnCallStringMustache
      FnCallSublist
      FnCallSum
      FnCallUnique
      FnCallUrlGet
      

      Making this consistent will clean up the code and the user experience, and will improve the maintenance experience for evalfunction.c significantly.

        Attachments

          Activity

            People

            • Assignee:
              a10040 Kristian Amlie
              Reporter:
              tzz Ted Zlatanov
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel