Uploaded image for project: 'CFEngine Community'
  1. CFEngine Community
  2. CFE-3652

Convert simple functions in string_lib.c to inline functions

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Rejected
    • Priority: Medium
    • Resolution: Won't Do
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: libutils
    • Labels:

      Description

      Many functions from string_lib.c can be easily inlined because they are very short and simple. At the same time they are called very often and the unnecessary function call instructions add up to a potentially significant overhead.

      Acceptance criteria:

      • functions that are less than 10 lines long converted to inline functions (may require moving them to string_lib.h, but not necessarily)
      • timing or callgrind results on an agent run showing the improvements

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                larsewi Lars Erik Wik
                Reporter:
                vpodzime Vratislav Podzimek
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel