Details
Description
With respect to verbose logs like:
verbose: Skipping loading of duplicate policy file /var/cfengine/inputs/lib/commands.cf
These messages clutter up the verbose log for something that I do not think we have had tickets about, so it's really just noise in most cases of reading a verbose log. Many of these are generated by the MPF itself, so it's rather expected.
I think that debug is a better fit.
Furthermore, the code in the same area already log "Loading policy file" to DEBUG as well.
Log(LOG_LEVEL_DEBUG, "Hashed policy file %s to %s", policy_file, hashbuffer); if (StringMapHasKey(policy_files_hashes, policy_file)) { Log(LOG_LEVEL_VERBOSE, "Skipping loading of duplicate policy file %s", policy_file); return NULL; } else if (StringSetContains(parsed_files_checksums, hashbuffer)) { Log(LOG_LEVEL_VERBOSE, "Skipping loading of duplicate (detected by hash) policy file %s", policy_file); return NULL; } else { Log(LOG_LEVEL_DEBUG, "Loading policy file %s", policy_file); }