Uploaded image for project: 'CFEngine Community'
  1. CFEngine Community
  2. CFE-3967

cfbs should not try to commit if there is no diff

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Open
    • Priority: Medium
    • Resolution: Unresolved
    • Affects Version/s: N/A
    • Fix Version/s: None
    • Component/s: cfbs
    • Labels:

      Description

      In this example I've manually made changes to cfbs.json by changing the version number of a module, cfbs update restores the previous content, thus there is no changes since last commit. Still cfbs tries to commit, which makes the commit fail.

       

      $ cfbs update
      The default commit message is 'Updated all modules' - edit it? [yes/y/NO/n] 
      Committing using git:
      On branch master
      nothing to commit, working tree clean
      Failed to commit changes
      Failed to commit changes, discarding them...
      

       

      Instead cfbs should be smart enough to check that there is actually a diff before trying to commit.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            larsewi Lars Erik Wik
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: