Uploaded image for project: 'Mender'
  1. Mender
  2. MEN-3360

Make state transition counter disregard state transitions caused by external input

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Priority: (None)
    • Resolution: Fixed
    • Affects Version/s: 2.3.0
    • Fix Version/s: 3.0.0
    • Labels:
    • Days in progress:
      4

      Description

      In the Mender client there is this mechanism, which counts the number of state transitions, and aborts (errors) the state loading if the number of state loadings has exceeded MaximumStateDataStoreCountExceeded. This causes the client to go straight back to the idle state. The reason for having this logic is to detect loops caused either caused by a faulty ArtifactRollbackVerifyReboot script (the only one that can loop), or a spontaneous reboot that keeps happening in one of the Update Module steps.

      The problem is that this does not take into account state transitions that happen because we are waiting for the server. This was fixed in a very crude way for retry operations, but these are still bounded by a certain number of executions. Ideally, the counter should not be increased at all as long as the input is coming from the server. This will allow it to wait indefinitely long.

      Acceptance criteria:

      • Find a way to not increase the state transition counter when it's a response from the server which is causing the state loop to happen.
      • Make server retries not increase the counter, and revert this.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                a10040 Kristian Amlie
                Reporter:
                a10040 Kristian Amlie
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel